[Date Prev][Date Next][Thread Prev][Thread Next] [Date Index] [Thread Index] [Home]

RE: "page extends" problem


At the moment, GNUJSP documents that if you wish to extend the page, use
org.gjt.jsp.HttpJspPageImpl as the parent.  It is an implementation issue
that needs to be fixed.

As I read the current code, there are several main sections in
JspServlet.needToRecompile().  One is:

  if (checkclass)
	check compiler version by call or reflection
	get previous dependencies by call or reflection

The other is:

  if (checkdependencies)
	assume servlet compiled in the future
	check for actual compile time by call or reflection
	for each dependency,
		if compile time older than last modified
			needtorecompile

It appears, just reading it quickly, that if the code cannot acquire the
compile time via call or reflection, that it will not recompile the class,
because the future is always newer than the past.  However, it should be
able to get that information; check the generated source for your pages, and
see if the _gnujsp... methods are in there.

I do have a question as to why the code isn't trying to get the lastmodified
date of the servlet file, as a more reasonable default than Long.MAX_VALUE.

	--- Noel

P.S. I'll be mostly off-line for the next 10 days, attending Colorado
Software Summit (http://www.softwaresummit.com/), the industry's best Java
conference.  If anyone else is attending, please be sure to say "Hi."